add exponential search algorithm #10732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… tests delete exponential_search.py file
algorithms-keeper
bot
added
awaiting reviews
cclauss
requested changes
Oct 21, 2023
searches/binary_search.py
Outdated
| @@ -297,6 +297,49 @@ def binary_search_by_recursion( | |||
| return binary_search_by_recursion(sorted_collection, item, midpoint + 1, right) | |||
|
|
|||
|
|
|||
| def exponential_search(sorted_collection: list[int], item: int) -> int | None: | |||
There was a problem hiding this comment.
I am not a fan of functions that return multiple datatypes. If the search fails, let's return -1 (like "Hello".find("Z")) or raise a ValueError (like "Hello".index("Z")).
Suggested change
| def exponential_search(sorted_collection: list[int], item: int) -> int | None: | |
| def exponential_search(sorted_collection: list[int], item: int) -> int: |
algorithms-keeper
bot
added
awaiting changes
Co-authored-by: Christian Clauss <[email protected]>
algorithms-keeper
bot
added
awaiting reviews
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 21, 2023
cclauss
reviewed
Oct 21, 2023
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
algorithms-keeper
bot
removed
the
tests are failing
|
I thought more about sorting the sorted collection… it is a bad idea. The second item in might be different in the two lists so the function might tell me that is the second item when in my list it is the third item. So, the implementations should raise ValueError on unsorted input. |
cclauss
approved these changes
Oct 21, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
|
@cclauss thank you for your suggestions :) |
|
@cclauss Since exponential search is a different algorithm from binary search, why was it placed in the |
cclauss
reviewed
Oct 26, 2023
| bound *= 2 | ||
| left = bound // 2 | ||
| right = min(bound, len(sorted_collection) - 1) | ||
| last_result = binary_search_by_recursion( |
There was a problem hiding this comment.
@tianyizheng02 exponential_search() embeds a call to binary_search_by_recursion() but as the benchmarks demonstrate delivers a faster result. Looking at the first commit makes this clearer.
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* add exponential_search algorithm * replace binary_search with binary_search_recursion * convert left type to int to be useable in binary_search_recursion * add docs and tests for exponential_search algorithm * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move exponential_search to binary_search.py to pass github auto build tests delete exponential_search.py file * Update searches/binary_search.py Co-authored-by: Christian Clauss <[email protected]> * remove additional space searches/binary_search.py Co-authored-by: Christian Clauss <[email protected]> * return single data type in exponential_search searches/binary_search.py Co-authored-by: Christian Clauss <[email protected]> * add doctest mod searches/binary_search.py Co-authored-by: Christian Clauss <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use // instread of int() convert searches/binary_search.py Co-authored-by: Christian Clauss <[email protected]> * change test according to new code searches/binary_search.py Co-authored-by: Christian Clauss <[email protected]> * fix binary_search_recursion multiple type return error * add a timeit benchmark for exponential_search * sort input of binary search to be equal in performance test with exponential_search * raise value error instead of sorting input in binary and exonential search to fix bugs * Update binary_search.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: user <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
added exponential algorithm using binary_search_recursion also tests and docs about it
Checklist: